note on AMD best practices #1478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sheppard It would be ideal if we could reference some quasi-authoritative document rather than just put the comment here. Where would be the best place to point people? |
|
The best reference is probably Though we could also link to the docs for |
|
Bug tracker ticket: http://bugs.jquery.com/ticket/14687 |
dmethvin
pushed a commit
that referenced
this pull request
Mar 13, 2014
Fixes #14687 Closes gh-1478 (cherry picked from commit 19220c0f29fa60d80a2beb76f048ffc8b972ba35) Conflicts: AUTHORS.txt
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
Fixes #14687 Closes jquerygh-1478 (cherry picked from commit 19220c0f29fa60d80a2beb76f048ffc8b972ba35) Conflicts: AUTHORS.txt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not surprisingly, jQuery has become the go-to example for developers looking to add an AMD definition to their library. As we know, jQuery's near ubiquity means that certain AMD recommendations are not practical for jQuery. Unfortunately, the jQuery named module registration is referenced with the (reasonable) assumption that it's representative of AMD best practices. For example discussions, see Leaflet/Leaflet#1364. Leaflet/Leaflet#1778, janl/mustache.js#333, janl/mustache.js#345 and d3/d3#1672.
I'm hoping an extra comment will make it clear that jQuery is a special case.